Update elastic #2047
Merged
Update elastic #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR enhances the elastic transform functionality by adding support for different noise distributions (Gaussian and uniform) in displacement field generation. The implementation refactors the displacement field generation code into a separate function and adds a new parameter to control the noise distribution type. Updated class diagram for ElasticTransformclassDiagram
class ElasticTransform {
+float alpha
+float sigma
+bool approximate
+bool same_dxdy
+Literal["gaussian", "uniform"] noise_distribution
+int mask_interpolation
+float p
+get_params_dependent_on_data(params: dict[str, Any], data: dict[str, Any]) dict[str, Any]
+get_transform_init_args_names() tuple[str, ...]
}
note for ElasticTransform "Added noise_distribution attribute and updated methods to use it."
Updated class diagram for generate_displacement_fields functionclassDiagram
class generate_displacement_fields {
+np.ndarray image_shape
+float alpha
+float sigma
+bool same_dxdy
+tuple[int, int] kernel_size
+np.random.Generator random_generator
+Literal["gaussian", "uniform"] noise_distribution
+generate_noise_field() np.ndarray
}
note for generate_displacement_fields "Refactored to include noise_distribution and generate_noise_field function."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider expanding the PR description to explain the motivation for adding the new noise distribution option and its expected benefits. This helps reviewers and future maintainers understand the context better.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
=========================================
+ Coverage 0 90.31% +90.31%
=========================================
Files 0 46 +46
Lines 0 7597 +7597
=========================================
+ Hits 0 6861 +6861
- Misses 0 736 +736 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2046
Summary by Sourcery
Add support for configurable noise distribution in the ElasticTransform class, allowing users to select between Gaussian and uniform distributions for displacement fields. Refactor related functions for improved clarity and update the pre-commit configuration to the latest Ruff version.
New Features:
Enhancements:
Build: